Skip to content

fix & enable clippy::match_same_arms - #13541

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:msa
Open

fix & enable clippy::match_same_arms#13541
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:msa

Conversation

@oech3

@oech3 oech3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 4.01%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 344 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation du_wide_tree[(5000, 500)] 22.9 ms 22 ms +4.01%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing oech3:msa (96f0097) with main (cee8424)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (93025b5) during the generation of this report, so cee8424 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@oech3
oech3 force-pushed the msa branch 2 times, most recently from 16c5e1c to d289dc0 Compare July 23, 2026 19:09
@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)

@oech3
oech3 marked this pull request as draft July 24, 2026 02:49
@oech3 oech3 mentioned this pull request Jul 24, 2026
Merged
sylvestre
sylvestre reviewed Jul 25, 2026
View reviewed changes
Comment thread src/uu/ls/src/colors.rs Outdated
@oech3

oech3 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

I'd split this since CI fails.

@oech3 oech3 mentioned this pull request Jul 25, 2026
Closed
@oech3
oech3 force-pushed the msa branch 13 times, most recently from 23c72b2 to e604a90 Compare July 30, 2026 09:04
@oech3

oech3 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

I think diff of this PR is small enough to review now.

@oech3
oech3 marked this pull request as ready for review July 30, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @sylvestre